Add logstash_stats_pipeline_flow_worker_ metrics, fix other flow metrics #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuskoman
force-pushed
the
add-new-metrics-v1
branch
from
ac2b46c
to
2394f3a
Compare
VCCPlindsten
reviewed
Oct 9, 2024
| @@ -165,6 +169,12 @@ type SinglePipelineResponse struct { | |||
| WithErrors int `json:"with_errors"` | |||
| Responses map[string]int `json:"responses"` | |||
| } `json:"bulk_requests"` | |||
| Flow struct { | |||
There was a problem hiding this comment.
This struct also exists in the "Filters" (but not codecs or inputs) object in the data returned from _node/stats
Not sure if important
There was a problem hiding this comment.
all right, added it to plugins, but not to metrics (at least for now, not sure whether somebody needs this stats, but should be quite easy to add it in the future)
|
I've tested this with logstash 8.11, which does not present the new metric, and it defaults to 0, which is a reasonable failure mode. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #365 and #366