Adapt transactron.lib.storage to amaranth.lib.data #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotro888
force-pushed
the
memory-lib-data
branch
from
4d637ca to
a34459d
Compare
|
for another PR? : missing granularity tests |
tilk
reviewed
Jan 14, 2025
tilk
approved these changes
Jan 15, 2025
tilk
reviewed
Jan 17, 2025
| return Mux(overflow_valid[i], overflow_data[i], read_port[i].data) | ||
|
|
||
| # Amaranth Mux drops lib.data Layouts | ||
| return {"data": View(self.shape, Mux(overflow_valid[i], overflow_data[i], read_port[i].data))} |
There was a problem hiding this comment.
Unfortunately this is a bug. If self.shape is not a data layout, this fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutListthat was latter flattened to unsigned shape. Now memory acceptsShapeLikeshape that is forwarded to memoryunsignedandArrayLayoutshapes asserted by amaranth)elem_counttodepthfor consistency with Amaranth