-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate hash aggregate finalization into its own operator #4913
Conversation
7badfe7
to
35c4b2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4913 +/- ##
=======================================
Coverage 86.51% 86.52%
=======================================
Files 1403 1403
Lines 60665 60686 +21
Branches 7461 7466 +5
=======================================
+ Hits 52484 52507 +23
+ Misses 8011 8010 -1
+ Partials 170 169 -1 ☔ View full report in Codecov by Sentry. |
Benchmark ResultMaster commit hash:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
This fixes the data race I mentioned in #4906. It's a little difficult to rigorously test since I was having a hard time reproducing it, but moving the finalization into a separate operator should guarantee that all threads running HashAggregate operator tasks finish before finalization starts.
I think this may fix the issue in #4903, but I'm not positive that it's the same issue.