Skip to content

[TransferEngine] Add tests for Topology #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

liusy58
Copy link
Contributor

@liusy58 liusy58 commented Jan 10, 2025

No description provided.

@alogfans
Copy link
Collaborator

LGTM

@@ -0,0 +1,81 @@
#include "topology.h"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge these cases into topology_test.cpp might be better?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@stmatengss stmatengss self-requested a review January 10, 2025 04:50
@alogfans alogfans merged commit 00ca6cd into kvcache-ai:main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants