engine: new interpreter, query planner #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Still need to rip out a lot of old stuff |
brennanjl
commented
Dec 17, 2024
node/engine2/interpreter/values.go
Outdated
| } | ||
| } | ||
|
|
||
| // valueToString converts a value to a string. |
There was a problem hiding this comment.
here is an example of converting values to a string and back
brennanjl
force-pushed
the
v0.10-sql-nodev2
branch
3 times, most recently
from
3d80b29 to
a2a2d11
Compare
|
Will write a more in-depth write-up tomorrow |
jchappelow
reviewed
Dec 19, 2024
jchappelow
reviewed
Dec 19, 2024
| @@ -1141,7 +1141,7 @@ func (c *DataType) PGString() (string, error) { | |||
| scalar = "UINT256" | |||
| case DecimalStr: | |||
| if c.Metadata == ZeroMetadata { | |||
| return "", fmt.Errorf("decimal type must have metadata") | |||
There was a problem hiding this comment.
I suppose we can actually git rm -r _previous/core/types
jchappelow
previously approved these changes
Dec 19, 2024
jchappelow
reviewed
Dec 19, 2024
Comment on lines
+1
to
+5
| /* | ||
| * A ANTLR4 grammar for Kuneiform. | ||
| * Developed by the Kwil team. | ||
| */ | ||
| parser grammar KuneiformParser; |
There was a problem hiding this comment.
@Yaiba I guess you've been in the loop on the antlr parser bits? I haven't gotten into this file at all, but I got the broad strokes on the intent.
There was a problem hiding this comment.
He should be. Quite a bit of the changes here were actually done by him
jchappelow
reviewed
Dec 19, 2024
jchappelow
reviewed
Dec 19, 2024
ripping old engine out replaced old engine removed parse references fixed lint issues delete testdata fix parse
brennanjl
force-pushed
the
v0.10-sql-nodev2
branch
from
4a39077 to
5b8d878
Compare
charithabandi
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1070.
A quick explanation of what changed (aside from the planned features and syntax changes to the engine):
parsemodule has been removed. All parsing is now done post-consensus (no parsers are needed by the client), so there was no longer a reason to keep it its own submodule.RawStatementtransaction, which takes any sort of statementcreate table,drop table,alter table,create action, and eveninsert/update/delete. There is a basic roles system that controls who can do execute these statements.db_ownerin the genesis file that specifies the initial schema owner. This is the first wallet that can create tables, actions, roles, etc.. This must be set for every network, since we no longer support anybody creating a schema.mainnamespace.infowhere all data about the current schema can be queried.