Cli punchlist #1272
Merged
Cli punchlist #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brennanjl
force-pushed
the
cli-punchlist
branch
from
2de910f to
420e683
Compare
jchappelow
reviewed
Jan 23, 2025
Comment on lines
+11
to
+14
| // wrapTextToTerminalWidth wraps text by detecting the current | ||
| // terminal width (columns) and using that as the wrap limit. | ||
| // If it can't get the terminal width, it will wrap it to 80 | ||
| func wrapTextToTerminalWidth(text string) string { |
There was a problem hiding this comment.
Excellent! The lack of wrapping has really stood out to me, but never took the time to propose a solution. 👍
jchappelow
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small punchlist items in kwil-cli that I am fixing as I make the docs. Nothing major here, just formatting changes for outputs or minor bug fixes.
Changes so far include:
kwil-cli utils generate-key--helpflag based on terminal widtharray_appendargs optionally be compatible Postgres, but kept our modified version as well.