forked from SammyLin/redactor-rails
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 5.1 #1
Open
krillatron
wants to merge
6
commits into
master
Choose a base branch
from
rails_v5.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rails 5.1 #1
Commits on Oct 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d59824f - Browse repository at this point
Copy the full SHA d59824fView commit details
Commits on Oct 25, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 15be69e - Browse repository at this point
Copy the full SHA 15be69eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8615985 - Browse repository at this point
Copy the full SHA 8615985View commit details
Commits on Apr 11, 2018
-
Fix the styling buttons in Chrome 65
* Fix the styling buttons (e.g. bold, italics) in Chrome 65 - and probably older. Stack Overflow suggests Chrome 58. * @dquilter fixed this originally in 8615985, however this behaviour is still broken in Sightsavers' ActiveAdmin. * There's an issue StackOverflow that seems to match the problem we're experiencing, and the accepted answer uses the solution applied by DQ, however the comments suggest this is only a partial fix, ref: * https://stackoverflow.com/q/43674400/885540 * https://stackoverflow.com/q/43674400/885540#comment75050875_43732840 * This applies the fix recommended by the comment, and that appears to have resolved the issue - though I'll be lying if I claim I know why `this.caret.set(node1, 0, node2, 0);` solves it.
Configuration menu - View commit details
-
Copy full SHA for 58de2c8 - Browse repository at this point
Copy the full SHA 58de2c8View commit details
Commits on Apr 12, 2018
-
Merge pull request #2 from kyan/fix-style-buttons-in-chrome-65
Fix the styling buttons in Chrome 65
Configuration menu - View commit details
-
Copy full SHA for 25c2f5c - Browse repository at this point
Copy the full SHA 25c2f5cView commit details
Commits on Apr 19, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 35b5f6b - Browse repository at this point
Copy the full SHA 35b5f6bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.