[pull] master from liferay:master #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a path for generating a zip file, we are passing a IProject object, that is not bound to the filesystem. Moreover, we now generate and return a JSZip file instead of writing it to a predefined path. This way we will be allowed to transform the given projectContent using some build tool without modifing the existing source code.
If we have some custom file path we might need to create directories before writing the file itself.
In order to avoid reloading the page accidentally, the url is being updated only if needed (adding/removing changed parameters). Moreover, now it is not necessary to specify if the selected fragment is a composition.
This can cause issues with fragments nested in subdirectories (like "collection/fragments/my-fragment/").
LPS-170383 Prepare new release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )