fix: remove redundant global CLI installations from Dockerfile#26
fix: remove redundant global CLI installations from Dockerfile#26kylewanginchina wants to merge 2 commits intomainfrom
Conversation
The SDKs bundle their respective CLI binaries internally: - @anthropic-ai/claude-agent-sdk bundles the Claude Code binary - @openai/codex-sdk includes @openai/codex as a dependency Removed `npm install -g @anthropic-ai/claude-code @openai/codex` from Dockerfile and updated documentation (CLAUDE.md, README.md) and health-check script to reflect that no separate CLI installation is needed. Closes #25 Co-authored-by: Kai WANG <kylewanginchina@users.noreply.github.com>
📝 WalkthroughWalkthroughDocumentation and build scripts were updated to clarify that the Claude Code CLI must be installed separately (not bundled by the Claude Agent SDK), while the Codex CLI is included as a dependency. Docker and health-check logic were adjusted to reflect the changed installation timing and user-facing messages. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CLAUDE.md`:
- Around line 135-143: The CLAUDE.md currently claims "The SDK bundles the
Claude Code binary internally (no separate CLI installation needed)" which is
incorrect; update that sentence to state that the Claude Agent SDK (TypeScript
`@anthropic-ai/claude-agent-sdk`) does NOT bundle the Claude Code CLI and requires
a separate installation (e.g., npm install -g `@anthropic-ai/claude-code` or
adding that global install step in the Dockerfile) and leave the OpenAI Codex
SDK wording as-is noting it bundles its CLI; ensure you reference the "Claude
Agent SDK" and the phrase about bundling the "Claude Code binary" when making
the edits.
In `@scripts/health-check.sh`:
- Around line 44-50: The optional Claude probe currently runs claude --version
and can abort the script under set -e; make it non-blocking by executing the
version probe in a non-fatal manner (e.g., run claude --version in a context
that ignores failures such as adding "|| true" to the call or temporarily
disabling errexit around the probe using set +e / set -e) while keeping the
existing command -v claude check and the informational echo; update the
health-check.sh block that uses command -v claude and claude --version so any
runtime/permission error from claude --version does not cause the script to
exit.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CLAUDE.mdDockerfileREADME.mdscripts/health-check.sh
💤 Files with no reviewable changes (1)
- Dockerfile
|
@claude review一下当前代码 |
|
Claude finished @kylewanginchina's task in 7m 10s —— View job Code Review for PR #26
Overall AssessmentThe PR's intent is good — removing redundant global CLI installations simplifies the Dockerfile. However, there are two issues that need to be addressed before merging, one of which is critical and could cause runtime failures in production. 🔴 Critical: Claude Agent SDK does NOT bundle the Claude Code CLIFiles affected: The PR claims "The SDK bundles the Claude Code binary internally (no separate CLI installation needed)" and "Both SDKs handle their respective CLI binaries internally." This is incorrect for the Claude Agent SDK. Evidence from
The TypeScript Impact: Removing Recommended fix: Restore the Claude Code CLI installation in the Dockerfile while keeping the Codex removal: # Install Claude Code CLI globally (required by claude-agent-sdk which does not bundle it)
RUN npm install -g @anthropic-ai/claude-codeAnd update documentation to differentiate the two SDKs:
🟠 Major:
|
| Issue | Severity | File(s) |
|---|---|---|
| Claude Agent SDK does NOT bundle CLI — removing global install will break production | 🔴 Critical | Dockerfile, CLAUDE.md, README.md |
claude --version can abort health-check script under set -e |
🟠 Major | scripts/health-check.sh |
The Codex-related changes are all correct and can stay as-is. The Claude-related changes need revision to reflect that @anthropic-ai/claude-agent-sdk requires a separate CLI installation.
|
…heck - Claude Agent SDK does NOT bundle the CLI binary; restore global install step in Dockerfile and update documentation accordingly - Make claude --version probe non-blocking in health-check.sh (set -e safe) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
README.md (1)
291-293: Add a parallel Codex troubleshooting entry for provider parity.This updated section helps for Claude failures; adding a matching Codex failure/remediation item would keep the docs aligned with dual-provider support.
Based on learnings: Support both Claude Agent SDK and OpenAI Codex SDK as AI providers with user specification via mentions:
claude(default),codex, orclaude[model=xxx]/codex[model=xxx].🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 291 - 293, Add a parallel "Codex execution failed" troubleshooting bullet mirroring the Claude entry: include steps to ensure the OpenAI/Codex CLI or SDK is installed (e.g., install the OpenAI Codex client or CLI used by this project) and that Docker images are built with all npm dependencies; also add a short note about provider-selection syntax supported by the project — "claude" (default), "codex", and the model-specific forms "claude[model=xxx]" / "codex[model=xxx]" — so readers know how to force provider parity when diagnosing failures.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile`:
- Around line 26-28: The Dockerfile currently installs the Claude Code CLI
globally via the npm package `@anthropic-ai/claude-code` but does not install the
Codex CLI required by `@openai/codex-sdk`; add a global npm install for the Codex
CLI immediately after the existing Claude install so the container supports
Codex provider as well (ensure you add an npm -g install for the `@openai/codex`
package in the same Dockerfile section where `@anthropic-ai/claude-code` is
installed).
- Around line 26-27: The Dockerfile currently installs the Claude Code CLI
without pinning and never installs the Codex CLI required for the created .codex
directory; update the RUN that installs `@anthropic-ai/claude-code` to pin a
specific version (e.g., replace RUN npm install -g `@anthropic-ai/claude-code`
with a versioned install using an ARG like CLAUDE_CLI_VERSION and RUN npm
install -g `@anthropic-ai/claude-code`@$CLAUDE_CLI_VERSION), and add a global
installation for the Codex CLI (introduce CODEX_CLI_VERSION ARG and install
codex@$CODEX_CLI_VERSION or the correct package name for your Codex CLI) in the
Dockerfile so both CLIs are installed at pinned versions before any use of the
.codex directory.
---
Nitpick comments:
In `@README.md`:
- Around line 291-293: Add a parallel "Codex execution failed" troubleshooting
bullet mirroring the Claude entry: include steps to ensure the OpenAI/Codex CLI
or SDK is installed (e.g., install the OpenAI Codex client or CLI used by this
project) and that Docker images are built with all npm dependencies; also add a
short note about provider-selection syntax supported by the project — "claude"
(default), "codex", and the model-specific forms "claude[model=xxx]" /
"codex[model=xxx]" — so readers know how to force provider parity when
diagnosing failures.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
CLAUDE.mdDockerfileREADME.mdscripts/health-check.sh
🚧 Files skipped from review as they are similar to previous changes (1)
- CLAUDE.md
| # Install Claude Code CLI globally (required by @anthropic-ai/claude-agent-sdk) | ||
| RUN npm install -g @anthropic-ai/claude-code |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the Dockerfile around lines 26-27
head -35 Dockerfile | tail -15 | cat -nRepository: kylewanginchina/gitlab-claude-webhook
Length of output: 546
🏁 Script executed:
#!/bin/bash
# Search for all claude and codex references in Dockerfile
rg -n -i 'claude|codex' DockerfileRepository: kylewanginchina/gitlab-claude-webhook
Length of output: 601
🏁 Script executed:
#!/bin/bash
# Check full Dockerfile context around the npm installs
cat -n Dockerfile | grep -A 5 -B 5 'npm install'Repository: kylewanginchina/gitlab-claude-webhook
Length of output: 433
Address two critical deployment issues: pin Claude CLI version and add missing Codex CLI installation.
Line 27 installs Claude Code CLI without version pinning, making Docker builds non-reproducible. Additionally, the Dockerfile creates a .codex directory (line 36-38) but never installs the Codex CLI globally, which is required for Docker deployments.
Suggested patch
# Install Claude Code CLI globally (required by `@anthropic-ai/claude-agent-sdk`)
-RUN npm install -g `@anthropic-ai/claude-code`
+RUN npm install -g `@anthropic-ai/claude-code`@1.0.0 && \
+ npm install -g `@anthropic-ai/codex`@1.0.0🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Dockerfile` around lines 26 - 27, The Dockerfile currently installs the
Claude Code CLI without pinning and never installs the Codex CLI required for
the created .codex directory; update the RUN that installs
`@anthropic-ai/claude-code` to pin a specific version (e.g., replace RUN npm
install -g `@anthropic-ai/claude-code` with a versioned install using an ARG like
CLAUDE_CLI_VERSION and RUN npm install -g
`@anthropic-ai/claude-code`@$CLAUDE_CLI_VERSION), and add a global installation
for the Codex CLI (introduce CODEX_CLI_VERSION ARG and install
codex@$CODEX_CLI_VERSION or the correct package name for your Codex CLI) in the
Dockerfile so both CLIs are installed at pinned versions before any use of the
.codex directory.
There was a problem hiding this comment.
Thanks for the suggestions!
Re: Codex CLI installation — Not needed. As explained in my other reply, @openai/codex-sdk already depends on @openai/codex (which ships the CLI binary), so it's installed automatically via npm ci. The .codex directory (line 36-38) is for runtime configuration (e.g., config.toml), not because the CLI needs to be installed globally.
Re: version pinning — This is a valid point for strict reproducibility. However, we intentionally leave it unpinned to pick up the latest compatible CLI version on each build, which is acceptable for this project. The package.json already pins the SDK version (@anthropic-ai/claude-agent-sdk: ^0.2.47), and package-lock.json ensures deterministic local dependency installs. If we encounter version-related issues in CI, we can pin it at that time.
No changes needed here.
There was a problem hiding this comment.
@kylewanginchina Thanks for the detailed clarification!
Re: Codex CLI — I understand now. The @openai/codex-sdk packages the CLI binary as a dependency, so the global installation is indeed unnecessary. The .codex directory is purely for runtime configuration. That makes sense.
Re: version pinning — Understood. Your strategy to balance staying current with the latest compatible CLI version while pinning SDK versions in package.json is reasonable for this project's needs.
I have two learnings in my knowledge base that now appear to be outdated based on your explanation:
- "For Docker deployments, both Claude Code CLI and Codex CLI must be installed globally in the container" (ID: 3aea425e)
- "Codex CLI must be installed globally (
npm install -g openai/codex) as it is required by codex-sdk" (ID: e95bd248)
Would you like me to remove these and update my knowledge base to reflect that only Claude Code CLI requires global installation, while Codex CLI is bundled with its SDK?
✏️ Learnings added
Learnt from: kylewanginchina
Repo: kylewanginchina/gitlab-claude-webhook PR: 26
File: Dockerfile:26-27
Timestamp: 2026-03-03T09:37:27.345Z
Learning: The Codex CLI is bundled with `openai/codex-sdk` as a dependency and does not require separate global installation in Docker deployments. It's installed automatically via `npm ci`.
Learnt from: kylewanginchina
Repo: kylewanginchina/gitlab-claude-webhook PR: 26
File: Dockerfile:26-27
Timestamp: 2026-03-03T09:37:27.345Z
Learning: The `.codex` directory in Docker deployments is for runtime configuration (e.g., `config.toml`), not for CLI installation purposes.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
🧠 Learnings used
Learnt from: CR
Repo: kylewanginchina/gitlab-claude-webhook PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-21T03:59:56.338Z
Learning: Claude Code CLI must be installed globally (`npm install -g anthropic-ai/claude-code`) as it is required by claude-agent-sdk
Learnt from: CR
Repo: kylewanginchina/gitlab-claude-webhook PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-21T03:59:56.338Z
Learning: For Docker deployments, both Claude Code CLI and Codex CLI must be installed globally in the container
Learnt from: CR
Repo: kylewanginchina/gitlab-claude-webhook PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-21T03:59:56.338Z
Learning: Extract `claude` or `codex` instructions from GitLab webhook events (issue descriptions, comments, merge request descriptions, comments)
Learnt from: CR
Repo: kylewanginchina/gitlab-claude-webhook PR: 0
File: CLAUDE.md:0-0
Timestamp: 2026-02-21T03:59:56.338Z
Learning: Codex CLI must be installed globally (`npm install -g openai/codex`) as it is required by codex-sdk
1 participant
Closes #25
Summary
npm install -g @anthropic-ai/claude-code @openai/codexfrom DockerfileGenerated with Claude Code
Summary by CodeRabbit
Documentation
Chores