Skip to content

Oanda #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylewidmann merged 6 commits into from
Feb 16, 2025
Merged

Oanda #16

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ebb22d7
Update broker to handle relative order sizing
kylewidmann Feb 14, 2025
6513222
Adding rel order size calculation to strategy
kylewidmann Feb 14, 2025
b071f2a
Remove order sizing from broker
kylewidmann Feb 14, 2025
e3c7485
Fix copysign call
kylewidmann Feb 14, 2025
af9d96e
Remove relative order sizing from strategy
kylewidmann Feb 16, 2025
73ef494
lint fixes
kylewidmann Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pytrade/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ def __new__(cls, *args, **kwargs):
# Need to handle case where instantiatied and different max size is provided
return cls.instance

def get(self, instrument: Instrument, granularity: Granularity):
def get(
self, instrument: Instrument, granularity: Granularity
) -> InstrumentCandles:
key = (instrument, granularity)
instrument_candles: InstrumentCandles = self._data.get(
key, InstrumentCandles(max_size=self._max_size)
Expand Down