Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Decouple build image job from e2e #1950

Merged
merged 8 commits into from
Oct 11, 2024
Merged

chore: Decouple build image job from e2e #1950

merged 8 commits into from
Oct 11, 2024

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Oct 10, 2024 •
edited
Loading

Description

The PR verifying: #1948

Related issue(s)
#1943

@ruanxin ruanxin requested a review from a team as a code owner October 10, 2024 14:29
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
c-pius
c-pius reviewed Oct 10, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some documentation in the build-image.yml what image tags are built? Also considering the different triggers that we support?

c-pius
c-pius approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@c-pius c-pius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we may consider to to externalize the compute tag to a separate action that we can share between repos. But for the sake of getting this fix in fast I would say we do that in a follow-up.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 10, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 11, 2024
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@ruanxin ruanxin merged commit af0c5cb into main Oct 11, 2024
36 of 37 checks passed
@c-pius c-pius deleted the decouple-build-image branch October 11, 2024 09:40
@c-pius c-pius assigned ruanxin and unassigned c-pius Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-pius c-pius c-pius approved these changes

Assignees

@ruanxin ruanxin

Labels
cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruanxin @kyma-bot @c-pius