chore: Replace Kyma CLI with modulectl in e2e #1966
Conversation
kyma-bot
added
cla: yes
| @@ -19,7 +19,7 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| make build-manifests | |||
| kyma alpha create module --module-config-file ./module-config.yaml --path . --registry localhost:5111 --insecure | |||
| module create --module-config-file ./module-config.yaml --registry http://localhost:5111 --insecure | |||
There was a problem hiding this comment.
We need to modify the module-config.yaml in the template-operator to have the defaultCR and manifest from the release URLs instead of the local file paths.
| @@ -19,7 +19,7 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| make build-manifests | |||
| kyma alpha create module --module-config-file ./module-config.yaml --path . --registry localhost:5111 --insecure | |||
| module create --module-config-file ./module-config.yaml --registry http://localhost:5111 --insecure | |||
There was a problem hiding this comment.
I suggest that we keep the Kyma CLI for this action since we agreed that the module teams will still be using the CLI until they have their modulereleasemeta in place. Also, this action will be removed after all modules are already using the modulereleasemeta.
Also, one more thing, using the modulectl generates the new format of the ModuleTemplate (and later on a different name ), and this will not be similar to the real modules' ModuleTemplates on landscapes
| @@ -29,6 +32,7 @@ runs: | |||
| echo "k8s_version=${{ github.event.inputs.k8s_version || '1.30.3' }}" >> $GITHUB_OUTPUT | |||
| echo "istio_version=1.20.3" >> $GITHUB_OUTPUT | |||
| echo "k3d_version=5.7.4" >> $GITHUB_OUTPUT | |||
| echo "modulectl_version=1.0.0" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
I think we need to document somewhere that we need to bump the modulectl version here when we do a new modulectl release, otherwise it might be forgotten?
There was a problem hiding this comment.
I guess if we want to use new features of it we need to bump it anyways?
There was a problem hiding this comment.
yes, but with the Kyma CLI we used the latest version, so it is a new thing to update the modulectl version for the E2E tests
There was a problem hiding this comment.
Alright. Any proposals where to document this?
There was a problem hiding this comment.
Is the modulectl release documented somewhere? Maybe we can add it there?
Description
Changes proposed in this pull request:
Related issue(s)