Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor manifest reconciler #1967

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

ruanxin
Copy link
Contributor

@ruanxin ruanxin commented Oct 17, 2024

Description

  • remove preDelete and PostRun hook
  • extract code related to manifest.status, finalizer to new package

Related issue(s)
#1830

- extract code related to manifest.status to new package
@ruanxin ruanxin requested a review from a team as a code owner October 17, 2024 11:37
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2024
…nd-metrics-for-Manifests-stuck-in-Deleting-state-due-to-DefaultCR-Warning
@ruanxin ruanxin requested a review from a team as a code owner October 17, 2024 11:49
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 18, 2024
@ruanxin ruanxin enabled auto-merge (squash) October 18, 2024 09:51
@ruanxin ruanxin merged commit b8f15be into kyma-project:main Oct 18, 2024
60 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants