remove duplicate componentDidMount (#531)

kyokan · Jul 6, 2022 · 534fb11 · 534fb11
1 parent 758fff2
commit 534fb11
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 18 deletions.
diff --git a/app/components/SendModal/index.js b/app/components/SendModal/index.js
@@ -75,10 +75,6 @@ class SendModal extends Component {
     hip2.setServers([`127.0.0.1:${props.hip2Port}`]);
   }
 
-  componentDidMount () {
-    analytics.screenView('Send');
-  }
-
   openLinkHandler (e) {
     e.preventDefault()
     shell.openExternal(e.target.href)
@@ -170,6 +166,7 @@ class SendModal extends Component {
 
   componentDidMount = () => {
     document.addEventListener('keydown', this.handleEscape)
+    analytics.screenView('Send');
   }
 
   componentWillUnmount = () => {

diff --git a/app/components/Transactions/index.js b/app/components/Transactions/index.js
@@ -58,9 +58,7 @@ export default class Transactions extends Component {
     this.setState({
       itemsPerPage: itemsPerPage || 5,
     });
-  }
 
-  async componentDidMount() {
     await this.props.fetchTransactions();
   }
 

diff --git a/app/pages/Auction/index.js b/app/pages/Auction/index.js
@@ -101,9 +101,6 @@ export default class Auction extends Component {
     } finally {
       this.setState({isLoading: false});
     }
-  }
-
-  componentDidMount() {
     analytics.screenView('Auction');
   }
 

diff --git a/app/pages/DomainManager/index.js b/app/pages/DomainManager/index.js
@@ -66,17 +66,15 @@ class DomainManager extends Component {
       || this.state.itemsPerPage !== nextState.itemsPerPage;
   }
 
-  componentDidMount() {
-    analytics.screenView('Domain Manager');
-  }
-
   async componentDidMount() {
     this.props.getMyNames();
     const itemsPerPage = await dbClient.get(DM_ITEMS_PER_PAGE_KEY);
 
     this.setState({
       itemsPerPage: itemsPerPage || 10,
     });
+
+    analytics.screenView('Domain Manager');
   }
 
   onChange = (name) => (e) => {

diff --git a/app/pages/MyDomain/index.js b/app/pages/MyDomain/index.js
@@ -38,9 +38,6 @@ class MyDomain extends Component {
   async componentDidMount() {
     await this.props.getNameInfo();
     await this.props.fetchPendingTransactions();
-  }
-
-  componentDidMount() {
     analytics.screenView('My Domains');
   }
 

diff --git a/app/pages/Watching/index.js b/app/pages/Watching/index.js
@@ -60,9 +60,7 @@ class Watching extends Component {
     this.setState({
       itemsPerPage: itemsPerPage || 10,
     });
-  }
 
-  componentDidMount() {
     analytics.screenView('Watching');
   }