This repository has been archived by the owner on Aug 28, 2022. It is now read-only.
refactor: decompose division #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronimizy
reviewed
Aug 28, 2021
|
close #67 |
ronimizy
suggested changes
Aug 29, 2021
|
Вернул обратно Division и изменения. Вынес фейкер. |
ronimizy
reviewed
Sep 12, 2021
ronimizy
suggested changes
Sep 12, 2021
Co-authored-by: ronimizy <71693183+ronimizy@users.noreply.github.com>
ronimizy
approved these changes
Nov 22, 2021
|
Kudos, SonarCloud Quality Gate passed! |
FrediKats
pushed a commit
that referenced
this pull request
Aug 15, 2022
refactor: decompose division
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Внезапно оказалось, что текущая реализация связей немного не работает. Сущность Division должна связывать множество групп в рамках одного предмета. Но это объединение не учебных групп. В системе явно не хватало сущности StudyGroupSubject - это как раз то, что описывает, что у определённой группы есть определённый предмет (и множество преподавателей). Это и есть единица, которую можно объединять в Division.
Это первый шаг к #38