remove the submit javascript call from the form to avoid Enter event … #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2024 05:09
This was referenced Oct 7, 2024
viniarck
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Much appreciated this fix @italovalcy. Let's ship it.
Also including @rmotitsuki as a reviewer in case he wants to review too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518
Summary
See updated changelog file for summary of the changes. Basically, although the form on mef_eline is trying to prevent premature submit upon Enter keyboard events, the submit event still leaks to the original form and ended up calling the
@clickevent will later send the premature request to MEF. After some unsuccessfully tries, I follow one suggestion to move the submit@clickevent caller to outside of the form and it worked. Looking into other usages of k-input-auto (sdntrace, sdntrace_cp and pathfinder), they don't even have forms (which makes sense, since we are handling all process on js).Local Tests
Tests after fixing Issue #518 and also fixing kytos-ng/ui#90
End-to-End Tests
Does not apply.