fix changes

Signed-off-by: Shubham Gupta <iamshubhamgupta2001@gmail.com>

pkg/test/step.go

@@ -4,15 +4,13 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"io"
 	"os"
 	"path/filepath"
 	"regexp"
 	"strings"
 	"testing"
 	"time"
 
-	"gopkg.in/yaml.v2"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -568,10 +566,6 @@ func (s *Step) LoadYAML(file string) error {
 				if err := validateTestStep(testStep, s.Dir); err != nil {
 					return fmt.Errorf("failed to validate TestStep object from %s: %v", file, err)
 				}
-				// Check for YAML errors in the TestStep file
-				if err := checkYAMLError(file); err != nil {
-					return fmt.Errorf("failed to check YAML in TestStep file %s: %v", file, err)
-				}
 				if s.Step != nil {
 					return fmt.Errorf("more than 1 TestStep not allowed in step %q", s.Name)
 				}
@@ -707,75 +701,20 @@ func validateTestStep(ts *harness.TestStep, baseDir string) error {
 		if _, err := os.Stat(path); os.IsNotExist(err) {
 			return fmt.Errorf("referenced file in Apply does not exist: %s", path)
 		}
-		if err := checkYAMLError(path); err != nil {
-			return err
-		}
 	}
 	// Check if referenced files in  Assert  exist
 	for _, assert := range ts.Assert {
 		path := filepath.Join(baseDir, assert)
 		if _, err := os.Stat(path); os.IsNotExist(err) {
 			return fmt.Errorf("referenced file in Assert does not exist: %s", path)
 		}
-		if err := checkYAMLError(path); err != nil {
-			return err
-		}
 	}
 	// Check if referenced files in  Error exist
 	for _, errorPath := range ts.Error {
 		path := filepath.Join(baseDir, errorPath)
 		if _, err := os.Stat(path); os.IsNotExist(err) {
 			return fmt.Errorf("referenced file in Error does not exist: %s", path)
 		}
-		if err := checkYAMLError(path); err != nil {
-			return err
-		}
-	}
-
-	return nil
-}
-
-func checkYAMLError(path string) error {
-	content, err := os.ReadFile(path)
-	if err != nil {
-		return fmt.Errorf("error reading file %s: %v", path, err)
-	}
-
-	decoder := yaml.NewDecoder(strings.NewReader(string(content)))
-	decoder.SetStrict(true)
-	for {
-		var data map[string]interface{}
-		if err := decoder.Decode(&data); err == io.EOF {
-			break
-		} else if err != nil {
-			return fmt.Errorf("YAML indentation or structural error in file %s: %v", path, err)
-		}
-
-		kind, ok := data["kind"].(string)
-		if !ok || kind == "" {
-			continue
-		}
-
-		if kind == "TestStep" {
-			allowedFields := map[string]bool{
-				"apply":      true,
-				"assert":     true,
-				"error":      true,
-				"delete":     true,
-				"index":      true,
-				"commands":   true,
-				"kubeconfig": true,
-				"unitTest":   true,
-				"metadata":   true,
-				"kind":       true,
-				"apiVersion": true,
-			}
-			for key := range data {
-				if _, ok := allowedFields[key]; !ok {
-					return fmt.Errorf("unexpected field %s in TestStep manifest in file %s", key, path)
-				}
-			}
-		}
 	}
 
 	return nil

pkg/test/utils/kubernetes.go

@@ -412,7 +412,7 @@ func ConvertUnstructured(in client.Object) (client.Object, error) {
 		return in, nil
 	}
 
-	err = runtime.DefaultUnstructuredConverter.FromUnstructured(unstruct, converted)
+	err = runtime.DefaultUnstructuredConverter.FromUnstructuredWithValidation(unstruct, converted, true)
 	if err != nil {
 		return nil, fmt.Errorf("error converting %s from unstructured error: %w", ResourceID(in), err)
 	}