Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent CVE-2023-5043 and CVE-2023-5044 #1015

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

kurktchiev
Copy link

@kurktchiev kurktchiev commented May 16, 2024

Description

Prevent CVE-2023-5043 and CVE-2023-5044

Checklist

  • I have read the policy contribution guidelines.
  • [] I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
@chipzoller
Copy link
Contributor

@kurktchiev, what's the plan with all these PRs in draft state? Looks like you are missing some things per the contribution guidelines.

Copy link
Author

@kurktchiev kurktchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kurktchiev, what's the plan with all these PRs in draft state? Looks like you are missing some things per the contribution guidelines.

@chipzoller i will move them out of draft state once i have added the required bits :)

@chipzoller
Copy link
Contributor

Following back up here, @kurktchiev, since I haven't seen any movement.

@kurktchiev
Copy link
Author

its on the docket for the week to get the remaining artifacts in

@chipzoller
Copy link
Contributor

Final bump on your PRs.

kurktchiev and others added 5 commits July 23, 2024 11:00
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
@kurktchiev kurktchiev marked this pull request as ready for review July 30, 2024 11:54
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This policy has no tests associated with it, only some test resources in the .kyverno directory.

kurktchiev and others added 4 commits July 30, 2024 10:59
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
Signed-off-by: Boris 'B' Kurktchiev <boris.kurktchiev@nirmata.com>
@realshuting
Copy link
Member

Hi @kurktchiev - I saw you added the test manifests, the last bit is to define a kyverno test folder so they can be checked upon CI jobs. See an example here.

@kurktchiev
Copy link
Author

Yep making my way through the PRs!

@kurktchiev kurktchiev marked this pull request as draft August 6, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants