Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add policy Restrict Cluster Role CSR #1077

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Add policy Restrict Cluster Role CSR #1077

merged 8 commits into from
Aug 2, 2024

Conversation

nsagark
Copy link
Contributor

@nsagark nsagark commented Jul 18, 2024

…tests, chainsaw tests and artifacthub-pkg.yaml

Related Issue(s)

Description

Checklist

  • I have read the policy contribution guidelines.
  • I have added test manifests and resources covering both positive and negative tests that prove this policy works as intended.
  • I have added the artifacthub-pkg.yml file and have verified it is complete and correct.

@nsagark
Added policy for restricting clusterroles for CSR's, along with unit …
ce91fd5 
…tests, chainsaw tests and artifacthub-pkg.yaml

Signed-off-by: nsagark <sagar@nirmata.com>
@nsagark
Copy link
Contributor Author

nsagark commented Jul 29, 2024

@chipzoller Please review this PR and let me know if any updates are needed.

chipzoller
chipzoller suggested changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@chipzoller chipzoller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to test, just a few minor updates. We need to wait to fix our CI so this can be tested.

other/restrict-clusterrole-csr/restrict-clusterrole-csr.yaml Outdated Show resolved Hide resolved
other/restrict-clusterrole-csr/restrict-clusterrole-csr.yaml Outdated Show resolved Hide resolved
other/restrict-clusterrole-csr/restrict-clusterrole-csr.yaml Outdated Show resolved Hide resolved
@nsagark
updated the policy with annotations and validation failure action
7768992 
Signed-off-by: nsagark <sagar@nirmata.com>
@nsagark
updated the sha256sum on the artifacthub-pkg.yaml
9c436ae 
Signed-off-by: nsagark <sagar@nirmata.com>
@nsagark
Copy link
Contributor Author

nsagark commented Jul 29, 2024

Hi @chipzoller I have updated the files. Please check.

@chipzoller
Update other/restrict-clusterrole-csr/artifacthub-pkg.yaml
59029f3 
Signed-off-by: Chip Zoller <chipzoller@gmail.com>
@chipzoller
Update other/restrict-clusterrole-csr/artifacthub-pkg.yaml
9e76c78 
Signed-off-by: Chip Zoller <chipzoller@gmail.com>
@chipzoller chipzoller changed the title Policy for restricting clusterroles for CSR's Add policy Restrict Cluster Role CSR Aug 2, 2024
@chipzoller chipzoller merged commit 3c6044b into kyverno:main Aug 2, 2024
280 checks passed
@nsagark nsagark mentioned this pull request Sep 9, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipzoller chipzoller chipzoller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsagark @chipzoller