Add InitContainers and EphermalContainers to Require Limits and Requests #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipzoller
suggested changes
Jul 31, 2024
There was a problem hiding this comment.
Thanks for this. Couple things:
- You must sign off on all commits (DCO).
- See contribution guide here, specifically the part about updating Artifact Hub metadata file.
best-practices/require-pod-requests-limits/require-pod-requests-limits.yaml
Outdated
Show resolved
Hide resolved
nikhilmaheshwari24
force-pushed
the
require-pod-requests-limits-with-all-containers
branch
2 times, most recently
from
3c09a9d
to
4099bae
Compare
3 tasks
|
Please sign-off your commits - https://github.com/kyverno/policies/pull/1103/checks?check_run_id=28177145454. |
Signed-off-by: Nikhil Maheshwari nikhil.m2498@gmail.com Signed-off-by: Nikhil Maheshwari <36232275+nikhilmaheshwari24@users.noreply.github.com>
Signed-off-by: Nikhil Maheshwari nikhil.m2498@gmail.com Signed-off-by: Nikhil Maheshwari <36232275+nikhilmaheshwari24@users.noreply.github.com>
nikhilmaheshwari24
force-pushed
the
require-pod-requests-limits-with-all-containers
branch
from
c3997ab
to
529b43d
Compare
|
@realshuting @chipzoller Could you please approve this? |
|
Unresolved conversations. |
|
You have not followed the contribution guide, specifically the part about updating |
Signed-off-by: Nikhil Maheshwari <36232275+nikhilmaheshwari24@users.noreply.github.com>
chipzoller
changed the title
chipzoller
approved these changes
Aug 2, 2024
|
@chipzoller I apologize. Have signed off the commits & updated the sha256sum to the I'll make sure such mistakes won't be repeated in future contributions. |
|
No problem. If the guide isn't clear, let us know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nikhil Maheshwari nikhil.m2498@gmail.com
Related Issue(s)
#951
Description
This PR updates the existing Kyverno policy to validate CPU and memory resource requests and limits for both containers and initContainers within Pods. This enhancement ensures comprehensive resource management across all container types in a Kubernetes cluster.
Checklist