L3af on windows #68
Open
L3af on windows #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthaler
reviewed
Aug 9, 2023
| @@ -71,4 +71,4 @@ enabled: false | |||
| # san-match-rules: .+l3afd.l3af.io,.*l3af.l3af.io,^l3afd.l3af.io$ | |||
|
|
|||
| [l3af-config-store] | |||
| filename: /var/l3afd/l3af-config.json | |||
| filename: /var/l3afd/l3af-config.json | |||
| - Clang | ||
| - nmake | ||
| - [Golang](https://aka.ms/vs/17/release/vs_buildtools.exe) | ||
| - C++ using: [MSYS2](https://www.msys2.org/) |
There was a problem hiding this comment.
Would be good to know why MSYS2 is needed, so we can work to remove that dependency
evershalik
requested review from
jniesz,
sanfern and
charleskbliu0
as code owners
evershalik
force-pushed
the
l3af-on-windows
branch
from
03b8375
to
1af6d94
Compare
|
Please rebase to resolve conflicts. |
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Co-authored-by: Dave Thaler <dthaler@microsoft.com> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: SHANKAR <shankar.s@ramanujan.du.ac.in> Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
evershalik
force-pushed
the
l3af-on-windows
branch
from
1af6d94
to
1efe406
Compare
delaramamiri
suggested changes
Sep 1, 2023
Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
Signed-off-by: evershalik <shankar.s@ramanujan.du.ac.in>
dthaler
reviewed
Oct 3, 2023
| @@ -0,0 +1,85 @@ | |||
| ## Installing Grafana and Prometheus on Windows System | |||
There was a problem hiding this comment.
Suggested change
| ## Installing Grafana and Prometheus on Windows System | |
| ## Installing Grafana and Prometheus on Windows | |
dthaler
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Why do you need images/l3af-on-windows/prometheus_grafana/Grafana_Dashboard1.png files in this PR? Shouldn't dashboard images not be windows specific?
|
|
||
| ### Installation of Prometheus as Service in Windows | ||
|
|
||
| You can download Prometheus for windows from https://prometheus.io/download/. However, installing prometheus as a service you need to use `NSSM explorer`. |
There was a problem hiding this comment.
Suggested change
| You can download Prometheus for windows from https://prometheus.io/download/. However, installing prometheus as a service you need to use `NSSM explorer`. | |
| You can download Prometheus for Windows from https://prometheus.io/download/. However, installing prometheus as a service you need to use `NSSM explorer`. | |
| For example: | ||
|  | ||
|
|
||
| Open `service.msc` and you can see prometheus service is installed |
There was a problem hiding this comment.
Suggested change
| Open `service.msc` and you can see prometheus service is installed | |
| Open `service.msc` and you can see the prometheus service is installed | |
|
|
||
| Navigate to prometheus `config file path` and open the “**prometheus.yml**” | ||
|
|
||
| You need to add job for `wmi exporter` and `l3afd` , as shown below: |
There was a problem hiding this comment.
Suggested change
| You need to add job for `wmi exporter` and `l3afd` , as shown below: | |
| You need to add a job for `wmi exporter` and `l3afd` , as shown below: | |
|
|
||
|  | ||
|
|
||
| Now you can access Prometheus service. |
There was a problem hiding this comment.
Suggested change
| Now you can access Prometheus service. | |
| Now you can access the Prometheus service. | |
|
|
||
|  | ||
|
|
||
| After starting Prometheus service, navigate to http://localhost:9090/ |
There was a problem hiding this comment.
nit: sometimes Prometheus is capitalized in this document, sometimes not. be consistent throughout.
|
|
||
|  | ||
|
|
||
| ## Grafana Dashboard files by l3af: |
There was a problem hiding this comment.
Suggested change
| ## Grafana Dashboard files by l3af: | |
| ## Grafana Dashboard files by L3AF: | |
|
|
||
| ### Steps to Build l3afd on Windows: | ||
|
|
||
| 1. Clone l3afd repo: |
There was a problem hiding this comment.
Suggested change
| 1. Clone l3afd repo: | |
| 1. Clone the l3afd repository: |
| cmake --build build | ||
| ``` | ||
|
|
||
| >l3afd.exe file will be created after this. |
There was a problem hiding this comment.
Suggested change
| >l3afd.exe file will be created after this. | |
| >l3afd.exe will be created after this. |
Co-authored-by: Dave Thaler <dthaler1968@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SHANKAR shankar.s@ramanujan.du.ac.in