-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update native loading of root programs #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
5 times, most recently
from
May 25, 2023 19:14
7fafb8e
to
9e68ff1
Compare
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
3 times, most recently
from
June 9, 2023 14:34
4a4ff26
to
9963150
Compare
dthaler
reviewed
Jun 13, 2023
dthaler
reviewed
Jun 13, 2023
dthaler
reviewed
Jun 13, 2023
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
3 times, most recently
from
June 16, 2023 12:57
9251c15
to
1617359
Compare
dthaler
reviewed
Jun 20, 2023
dthaler
reviewed
Jun 20, 2023
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
2 times, most recently
from
June 21, 2023 20:04
39c6ade
to
6b2eaad
Compare
ajayR006
previously approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- API Documentation for this change is necessary
- Release note explaining added capability, bugs and the missing features plan for next milestone.
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
3 times, most recently
from
June 24, 2023 20:30
a6bfce3
to
c706528
Compare
dthaler
previously approved these changes
Jun 27, 2023
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
from
August 1, 2023 14:02
d4f6395
to
71e1b64
Compare
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
from
August 18, 2023 18:27
4e02c69
to
051c17c
Compare
jniesz
reviewed
Aug 24, 2023
Signed-off-by: Santhosh Fernandes <santhosh.fernandes@gmail.com>
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
from
August 25, 2023 14:40
97352db
to
282801f
Compare
jniesz
reviewed
Aug 25, 2023
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
4 times, most recently
from
August 26, 2023 06:18
b8c151a
to
b3232a9
Compare
This was referenced Aug 29, 2023
Merged
Merged
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
3 times, most recently
from
August 30, 2023 09:35
c4566fd
to
d04dee3
Compare
Signed-off-by: sferna1 <santhosh.fernandes@gmail.com>
sanfern
force-pushed
the
sanfern-dev-root-progs
branch
from
August 30, 2023 09:44
d04dee3
to
1231e54
Compare
dthaler
approved these changes
Aug 30, 2023
jniesz
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates loading and unloading of the xdp root and tc root programs from L3afd. An XDP root program as well as TC filters are attached to the interface.The process of unloading xdp and tc programs is a common one, when the programs are loaded by L3AFD.
The next PR will include the loading of other ebpf programs from L3afd.