Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report users #163

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Report users #163

merged 1 commit into from
Nov 4, 2022

Conversation

Flowtter
Copy link
Contributor

Add a report option.
Useful to report an user or a message.
Available in:

  • profile
  • radial menu
  • messages
2022-10-11.14-45-37.mp4

@ramnes ramnes added the enhancement New feature or request label Oct 11, 2022
@Flowtter Flowtter marked this pull request as draft October 11, 2022 14:52
@Flowtter Flowtter marked this pull request as ready for review October 26, 2022 12:33
@ramnes ramnes requested a review from Donorhan October 26, 2022 13:45
@Donorhan
Copy link
Contributor

This is a great idea for open levels, thanks! Would it be possible to move this to a module? The "modules" folder, I think you can put the css, hbs and JS in there. For the integration in the radial menu and other interfaces I could do it in a second time if you are not comfortable with that

@Flowtter
Copy link
Contributor Author

Flowtter commented Oct 27, 2022

ACK, I'll have a look next week probably !
Thanks for the fast feedback after the reopening off the PR.

@Flowtter
Copy link
Contributor Author

Flowtter commented Oct 28, 2022

I moved the three specified files, however, since @alimtunc is working on a ban feature, we agreed to let him extend this PR.

@alimtunc
Copy link
Contributor

For the integration in the radial menu and other interfaces I could do it in a second time if you are not comfortable with that

What do you mean ? I don't see anything wrong with the implement, did I missed something ? 🙂

@Donorhan
Copy link
Contributor

@alimtunc Sorry, maybe I misspoke. Instead of directly editing the radial-menu.js file to add the option, you can do something like I did in the textual-communication-tools.js:

 registerModules(
    [
      { id: 'report', icon: '🚨️', order: 4, label: 'Report', shortcut: 53, closeMenu: true, scope: 'other' },
    ],
    moduleType.RADIAL_MENU,
  );

And add a listener on the radial menu in the report.js file with:

window.addEventListener(eventTypes.onMenuOptionSelected, onMenuOptionSelected);

The advantage of this is that the core is not aware of the existence of your module and you can remove the module without affecting the simulation.

Copy link
Contributor

@Donorhan Donorhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you 🙏🏻

@Donorhan Donorhan merged commit 783f776 into l3mpire:master Nov 4, 2022
@Flowtter Flowtter deleted the report branch November 4, 2022 10:08
xsyann pushed a commit to Refty/lemverse that referenced this pull request Nov 14, 2022
xsyann pushed a commit to Refty/lemverse that referenced this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants