Skip to content

fix(ChordDisplay): allow keyboard key height up to 16 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
# 1.6.0 (2023-12-11)
# 1.6.1 (2023-12-11)

## Fixes
- **Chord Display:** allow keyboard key height up to 16

# 1.6.0 (2023-12-23)

## Features
- **Chord Display:** Fully customizable Piano (sizes, colors and labels above keys)
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "midi-jar",
"version": "1.6.0",
"version": "1.6.1",
"description": "A MIDI tool box for displaying chords and notes, routing devices, and more",
"main": "./src/main/main.ts",
"scripts": {
Expand Down
4 changes: 2 additions & 2 deletions release/app/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion release/app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "midi-jar",
"version": "1.6.0",
"version": "1.6.1",
"description": "A MIDI tool box for displaying chords and notes, routing devices, and more",
"license": "MIT",
"author": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ const ChordDisplayModuleSettings: React.FC<Props> = ({ parentPath }) => {
value={moduleSettings.keyboard.sizes.height}
onChange={(value: number) => updateModuleSetting('keyboard.sizes.height', value)}
min={1}
max={8}
max={16}
step={0.1}
valueText={`${moduleSettings.keyboard.sizes.height}`}
/>
Expand All @@ -277,8 +277,8 @@ const ChordDisplayModuleSettings: React.FC<Props> = ({ parentPath }) => {
onChange={(value: number) => updateModuleSetting('keyboard.sizes.ratio', value)}
min={0.1}
max={0.9}
step={0.05}
valueText={`${Math.round(moduleSettings.keyboard.sizes.ratio * 100)}%`}
step={0.025}
valueText={`${(moduleSettings.keyboard.sizes.ratio * 100).toFixed(1)}%`}
/>
</FormField>
)}
Expand Down