Skip to content

feat: Chord Dictionary module #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 5, 2024
Merged

Conversation

ArTiSTiX
Copy link
Contributor

@ArTiSTiX ArTiSTiX commented Dec 19, 2023

A super module to explore the chord dictionary loaded in tonaljs

image

@ArTiSTiX ArTiSTiX force-pushed the feat/chord-dictionary-module branch from a6c50a9 to 52ba082 Compare January 4, 2024 10:11
{chord.intervals.map((_, index) => {
if (!index) return null;

const interval = chord.intervals[index].replace('*', '');

Check failure

Code scanning / CodeQL

Incomplete string escaping or encoding

This replaces only the first occurrence of '*'.
@ArTiSTiX ArTiSTiX force-pushed the feat/chord-dictionary-module branch 6 times, most recently from 1981b28 to 2f380b1 Compare January 5, 2024 08:15
@ArTiSTiX ArTiSTiX force-pushed the feat/chord-dictionary-module branch from 2f380b1 to 1cebc7f Compare January 5, 2024 08:19
@ArTiSTiX ArTiSTiX force-pushed the feat/chord-dictionary-module branch from 1cebc7f to 02c1b81 Compare January 5, 2024 08:24
@ArTiSTiX ArTiSTiX merged commit 3deebee into main Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant