remote/exporter: fix info message for version #1573
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We receive the coordinator version in the hello message from the coordinator on the exporter side. Correctly print out that we connected to a coordinator with the sent back version instead of confusingly printing that this is the exporter version. Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
jluebbe
force-pushed
the
fix-version-message
branch
from
0c6b8ab to
7b4736f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
======================================
Coverage 56.2% 56.2%
======================================
Files 170 170
Lines 13248 13218 -30
======================================
- Hits 7449 7436 -13
+ Misses 5799 5782 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We receive the coordinator version in the hello message from the coordinator on the exporter side. Correctly print out that we connected to a coordinator with the sent back version instead of confusingly printing that this is the exporter version.