Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Waveshare Modbus Relays #1575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ep1cman
Copy link
Contributor

@ep1cman ep1cman commented Jan 21, 2025

Waveshare only implement the ability to query the status of all relays (https://www.waveshare.com/wiki/Modbus_RTU_Relay#Read_States_of_Relays) not just one, so a modification to the existing drivers is required.

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • Add a section on how to use the feature to doc/usage.rst
  • Add a section on how to use the feature to doc/development.rst
  • PR has been tested
  • Man pages have been regenerated

Waveshare only implement the ability to query the status of all relays
(https://www.waveshare.com/wiki/Modbus_RTU_Relay#Read_States_of_Relays)
not just one, so a modification to the existing drivers is required.

Signed-off-by: Sebastian Goscik <sebastian.goscik@arm.com>
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 46.15385% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.2%. Comparing base (fff35ee) to head (60e5af1).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/driver/modbusdriver.py 41.1% 10 Missing ⚠️
labgrid/remote/client.py 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1575     +/-   ##
========================================
- Coverage    56.2%   56.2%   -0.1%     
========================================
  Files         170     170             
  Lines       13248   13271     +23     
========================================
+ Hits         7449    7460     +11     
- Misses       5799    5811     +12     
Flag Coverage Δ
3.10 56.2% <46.1%> (-0.1%) ⬇️
3.11 56.2% <46.1%> (-0.1%) ⬇️
3.12 56.2% <46.1%> (-0.1%) ⬇️
3.13 56.1% <46.1%> (-0.1%) ⬇️
3.9 56.2% <46.1%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant