improve handing of background tasks in the coordinator #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
With many resources, yaml.dump(resources) takes a few seconds. To avoid blocking the main loop for this long, make a copy and serialize via a threaded executor. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Reacquiring orphaned resources can take some time, but we don't want to block saving or scheduling in the meantime, so split them into separate asyncio tasks. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
As the state is saved in a separate thread, longer times are not as problematic, so move them to debug log level. Signed-off-by: Jan Luebbe <jlu@pengutronix.de>
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #1579 +/- ##
========================================
- Coverage 56.1% 56.0% -0.1%
========================================
Files 170 170
Lines 13287 13306 +19
========================================
Hits 7458 7458
- Misses 5829 5848 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Emantor
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With many places and resources, saving them can take seconds and block the main loop.
Avoid that by moving that off to an executor thread.
Also split the background tasks so they don't block each other needlessly.