Skip to content

Conversation

adrian-cph
Copy link

No description provided.

@esmil
Copy link
Member

esmil commented Jun 21, 2024

Hi Adrian,

It looks good except for the weird extra whitespace. I can remove that when committing, but your commits seem to be from adrian-cph <163692213+adrian-cph@users.noreply.github.com>. I would have expected something like Adrian Hansen <your@real.email>

You should be able to fix it with

git config --global user.name 'Adrian Hansen'
git config --global user.email 'your@real.email'
git rebase -r origin/master --exec 'git commit --amend --no-edit --reset-author'

..and then force push the new version to the same users-adrian-add branch in your github fork to update this pull request.

@adrian-cph
Copy link
Author

Thank you for the input i will fix these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants