Issue JedWatson#5733: MenuPlacer useLayoutEffect depend on isLoading

labkey-nicka · Oct 4, 2023 · 0b3c34f · 0b3c34f
1 parent b53e647
commit 0b3c34f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/react-select/src/Select.tsx b/packages/react-select/src/Select.tsx
@@ -1961,7 +1961,7 @@ export default class Select<
     };
 
     const menuElement = (
-      <MenuPlacer {...commonProps} {...menuPlacementProps}>
+      <MenuPlacer {...commonProps} {...menuPlacementProps} isLoading={isLoading}>
         {({ ref, placerProps: { placement, maxHeight } }) => (
           <Menu
             {...commonProps}

diff --git a/packages/react-select/src/components/Menu.tsx b/packages/react-select/src/components/Menu.tsx
@@ -266,6 +266,7 @@ export interface MenuPlacerProps<
     MenuPlacementProps {
   /** The children to be rendered. */
   children: (childrenProps: ChildrenProps) => ReactElement;
+  isLoading: boolean;
 }
 
 function alignToControl(placement: CoercedMenuPlacement) {
@@ -317,6 +318,7 @@ export const MenuPlacer = <
 ) => {
   const {
     children,
+    isLoading,
     minMenuHeight,
     maxMenuHeight,
     menuPlacement,
@@ -353,6 +355,7 @@ export const MenuPlacer = <
     setPlacement(state.placement);
     setPortalPlacement?.(state.placement);
   }, [
+    isLoading,
     maxMenuHeight,
     menuPlacement,
     menuPosition,