Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify rke2 artifact path #256

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

simplify rke2 artifact path #256

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bad0af7
simplify rke2 artifact path
Oct 10, 2024
df12e80
also install script dir
Oct 10, 2024
76816cb
fix nonsensical loop
Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ rke2_data_path: /var/lib/rancher/rke2
rke2_artifact_url: https://github.com/rancher/rke2/releases/download/

# Local path to store artifacts
rke2_artifact_path: /rke2/artifact
rke2_artifact_path: /var/tmp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are gonna change it, let's change it to the path which is used in the RKE2 Docs https://docs.rke2.io/install/airgap (/root/rke2-artifacts)


# Airgap required artifacts
rke2_artifact:
Expand Down Expand Up @@ -174,7 +174,7 @@ rke2_tarball_images_path: "{{ rke2_data_path }}/agent/images"
rke2_architecture: amd64

# Destination directory for RKE2 installation script
rke2_install_script_dir: /var/tmp
rke2_install_script_dir: "{{ rke2_install_script_dir }}"
simonfelding marked this conversation as resolved.
Show resolved Hide resolved

# RKE2 channel
rke2_channel: stable
Expand Down
4 changes: 2 additions & 2 deletions defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ rke2_data_path: /var/lib/rancher/rke2
rke2_artifact_url: https://github.com/rancher/rke2/releases/download/

# Local path to store artifacts
rke2_artifact_path: /rke2/artifact
rke2_artifact_path: /var/tmp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are gonna change it, let's change it to the path which is used in the RKE2 Docs https://docs.rke2.io/install/airgap (/root/rke2-artifacts)


# Airgap required artifacts
rke2_artifact:
Expand Down Expand Up @@ -136,7 +136,7 @@ rke2_tarball_images_path: "{{ rke2_data_path }}/agent/images"
rke2_architecture: amd64

# Destination directory for RKE2 installation script
rke2_install_script_dir: /var/tmp
rke2_install_script_dir: "{{ rke2_install_script_dir }}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a loop

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, nice catch. My brain must have turned off while making that commit.


# RKE2 channel
rke2_channel: stable
Expand Down
Loading