node-local-dns #1
Conversation
values.tf
Outdated
| "serviceAccount" : { | ||
| "create" : true, | ||
| "annotations" : {}, | ||
| "name" : "" |
There was a problem hiding this comment.
Please fix alignment with module input variables:
- var.service_account_create
- var.service_account_name
- IRSA machinery annotations
There was a problem hiding this comment.
Please use patterns we are using in other addons, for example please see:
| @@ -1,9 +1,132 @@ | |||
| locals { | |||
| values_default = yamlencode({ | |||
There was a problem hiding this comment.
Some of the defaults are also defaults in the Helm chart that is used under the hood (https://github.com/lablabs/k8s-nodelocaldns-helm/blob/master/charts/node-local-dns/values.yaml). I think we can remove the same defaults and configure only AWS EKS specific values.
There was a problem hiding this comment.
agree but same as the irsa, i will check it in second iteration.
There was a problem hiding this comment.
Fine by me, please, just raise a Jira ticket for this work so we got it tracked.
|
@dojci now the PR is ready to be reviewed |
values.tf
Outdated
| } | ||
| }) | ||
|
|
||
| release_name_suffixed = "${var.helm_release_name}-${one(random_pet.release_name_suffix[*].id)}" |
There was a problem hiding this comment.
release_name_suffixed -> helm_release_name
Description
Initial addon setup
Type of change
fix)feat)refactor)test)style)ci)docs)How Has This Been Tested?