feat(BA-615): Collect metrics for the RPC server #3555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:agent
HyeockJinKim
force-pushed
the
feat/add-rpc-metrics
branch
2 times, most recently
from
6d265ad to
f605742
Compare
HyeockJinKim
force-pushed
the
feat/add-rpc-metrics
branch
from
f605742 to
6c3fe58
Compare
fregataa
reviewed
Feb 20, 2025
| duration=duration, | ||
| ) | ||
| return res | ||
| except Exception as e: |
There was a problem hiding this comment.
How about handling BaseException here?
|
|
||
| def __init__(self) -> None: | ||
| self.functions = set() | ||
| self._metric_observer = RPCMetricObserver.instance() |
There was a problem hiding this comment.
Is it used as a singleton object? Is it expected to use this observer in other context?
Comment on lines
+203
to
+206
| def _collect_metrics(observer: RPCMetricObserver) -> Callable: | ||
| def decorator(meth: Callable) -> Callable[[AgentRPCServer, RPCMessage], Any]: | ||
| @functools.wraps(meth) | ||
| async def _inner(self: AgentRPCServer, *args, **kwargs) -> Any: |
There was a problem hiding this comment.
We can apply more strict type hints here but then we have to update the type hints of RPCFunctionRegistry.__call__().
Let's leave it as a minor issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3549 (BA-615)
Checklist: (if applicable)
ai.backend.testdocsdirectory