fix(BA-584): Remove foreign key constraint from EndpointRow.image column
#3599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
jopemachine
changed the title
EndpointRow.image columnEndpointRow.image column
jopemachine
changed the title
EndpointRow.image columnEndpointRow.image column
jopemachine
force-pushed
the
fix_image_deletion_not_working_due_to_endpoint_fk
branch
from
44d8c6a to
2b3e888
Compare
HyeockJinKim
approved these changes
Feb 7, 2025
HyeockJinKim
deleted the
fix_image_deletion_not_working_due_to_endpoint_fk
branch
lablup-octodog
pushed a commit
that referenced
this pull request
Feb 7, 2025
…olumn (#3599) Backported-from: main (25.1) Backported-to: 24.03 Backport-of: 3599
lablup-octodog
pushed a commit
that referenced
this pull request
Feb 7, 2025
…olumn (#3599) Backported-from: main (25.1) Backported-to: 24.09 Backport-of: 3599
This was referenced Feb 7, 2025
lablup-octodog
pushed a commit
that referenced
this pull request
Feb 7, 2025
…olumn (#3599) Backported-from: main (25.1) Backported-to: 23.09 Backport-of: 3599
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3509 (BA-584).
This PR prevents issues like #3509 by removing the foreign key constraint on
EndpointRow.image.It also modifies the
EndpointRow.imagecolumn to be conditionally nullable.EndpointRow.imagecan only be null when in the "Destroyed" state.This prevents the creation of a new session with an empty image when
EndpointRow.replicasis modified.Checklist: (if applicable)