[DO NOT MERGE]: feat(RAIN-66370): add support in the CLI for existing topic and sub for GCP Pub/Sub Audit Log #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afiune
reviewed
Aug 1, 2023
| @@ -199,7 +199,6 @@ locally you need to setup the following environment variables and use the direct | |||
| `make integration`, an example of the command you can use is: | |||
| ``` | |||
| CI_ACCOUNT="<YOUR_ACCOUNT>" \ | |||
| CI_V1_ACCOUNT="<YOUR_V1_CONFIG_ACCOUNT>" \ | |||
dmurray-lacework
force-pushed
the
RAIN-66370-cli-support-gcpv2-manual-migration
branch
from
f3e9df6
to
3714b24
Compare
…/github.com/lacework/go-sdk into RAIN-66370-cli-support-gcpv2-manual-migration fix: merge
Signed-off-by: Darren Murray <darren.murray@lacework.net>
djmctavish
approved these changes
Aug 3, 2023
Manan-Bhatia-0
changed the title
|
won't do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds advanced configuration options to allow the user to specify the names of an existing pub/sub topic and subscription while configuring a gcp pub/sub audit log integration via the
lacework generate cloud-account gcpcommand. Below are the new options added:UseExistingPubSubTopicUseExistingPubSubSubscription--existing_pub_sub_topic_id--existing_pub_sub_subscription_nameHow did you test this change?
Changes were tested by adding tests in code as well as by building the CLI and testing end-to-end with terraform to ensure that the new inputs were accepted by the CLI, and subsequently used by terraform to use those existing resources (changes were also required on the terraform side, and here is the PR for that.)
Screenshot:
Issue
RAIN-66370