Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(resource-groups): add per-group-type templates #1414

Merged
merged 7 commits into from
Oct 17, 2023
Merged

feat(resource-groups): add per-group-type templates #1414

merged 7 commits into from
Oct 17, 2023

Conversation

hazedav
Copy link
Collaborator

@hazedav hazedav commented Oct 13, 2023

Summary

This pull-request adds a template for each RGv2 type (i.e. AWS, GCP, AZURE, OCI, MACHINE, CONTAINER). This makes it easier for our customers to create resource groups via the CLI+Editor

How did you test this change?

  • Manually
  • Augmented delete integration test to iterate through each type

Issue

https://lacework.atlassian.net/browse/GROW-2489

@hazedav hazedav requested a review from a team as a code owner October 13, 2023 19:45
@hazedav
Copy link
Collaborator Author

hazedav commented Oct 13, 2023

@hazedav
Copy link
Collaborator Author

hazedav commented Oct 13, 2023

integration all

@hazedav
Copy link
Collaborator Author

hazedav commented Oct 13, 2023

integration all

@hazedav
feat(resource-groups): add per-group-type templates
c3e91c8 
Handle errors in createResourceGroup (test)

GROW-2489
@hazedav
Copy link
Collaborator Author

hazedav commented Oct 13, 2023

integration all

zekisherif
zekisherif reviewed Oct 16, 2023
View reviewed changes
api/resource_groups.go Outdated Show resolved Hide resolved
zekisherif
zekisherif approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@zekisherif zekisherif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

afiune
afiune approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afiune afiune merged commit 2ccd309 into main Oct 17, 2023
2 checks passed
@afiune afiune deleted the GROW-2489 branch October 17, 2023 17:07
@lacework-releng lacework-releng mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekisherif zekisherif zekisherif approved these changes

@afiune afiune afiune approved these changes

@dmurray-lacework dmurray-lacework Awaiting requested review from dmurray-lacework

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hazedav @afiune @zekisherif