fix(telemetry): record silent error #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
ipcrm
reviewed
Mar 7, 2024
Comment on lines
+201
to
+207
| defer func() { | ||
| cli.Event.Feature = featDailyVerCheck | ||
| if err != nil { | ||
| cli.Event.FeatureData = map[string]interface{}{"silent_error": err.Error()} | ||
| } | ||
| cli.SendHoneyvent() | ||
| }() |
There was a problem hiding this comment.
Will the CLI always stay running long enough for this to send? Looks like the daily check is called in the post-execution of the root command.
There was a problem hiding this comment.
Yup. We have workers in place to wait for this. https://github.com/lacework/go-sdk/blob/main/cli/cmd/honeyvent.go#L115-L124
ipcrm
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should not fail (in Honeycomb) when we can't check for updates, instead we are going to
send a silent error.
How did you test this change?
Built it and ran CLI locally, saw Honeycomb dev dataset.
Before
After