fix(cli): avoid panic while updating progress #1597
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While installing new component, we are seeing a panic similar to:
This is due to the fact that we were updating the progress
Suffix
unsafely. The fix is to use theCLI functions to start a new progress every time we have an update inside the download func.
Additional things in this PR:
test-only
to run only unit tests withoutprepare
EOF
error we are seeingHow did you test this change?
Updated tests and ran multiple
install
anduninstall
.Issue
https://lacework.atlassian.net/browse/GROW-2765