feat(cli): CLI guided config support for creating Azure AD integration #1628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipcrm
suggested changes
May 28, 2024
| } | ||
|
|
||
| // Ensure all combinations of inputs are valid for supported spec | ||
| func (args *GenerateAzureTfConfigurationArgs) validate() error { | ||
| // Validate one of config or activity log was enabled; otherwise error out | ||
| if !args.ActivityLog && !args.Config { | ||
| if !args.ActivityLog && !args.Config && !args.EntraIdActivityLog { | ||
| return errors.New("audit log or config integration must be enabled") |
There was a problem hiding this comment.
EntraID is still audit log so I didn't change the error message, because right now the users have the option to create audit log with either option, but I did add it to the if-condition check.
…N-93116-cli-guided-config-azure-ad
Manan-Bhatia-0
requested review from
zekisherif,
mjunglw and
leijin-lw
and removed request for
a team
leijin-lw
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support to create an Azure Entra ID (formerly Active Directory) activity log integration with LW. Support is added for both, manual and guided config.
How did you test this change?
Screenshots [CLI]:
Issue
RAIN-93116