Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GROW-2950): disable use of gcp storage audit from generate #1643

Merged
merged 11 commits into from
Jul 16, 2024

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Jun 13, 2024

Summary

Disable the ability to generate GCP audit log integration that use the previous storage method. Only generate pub/sub style gcp audit log integrations.

How did you test this change?

Validated tests run successfully and ran through manual generation; the delta (new vs old):

diff /home/coder/lacework/gcp/main.tf /home/coder/lacework/gcp/main.tf.old
41,42c41,42
<   source                       = "lacework/pub-sub-audit-log/gcp"
<   version                      = "~> 0.2"
---
>   source                       = "lacework/audit-log/gcp"
>   version                      = "~> 3.4"

Issue

https://lacework.atlassian.net/browse/GROW-2950

@ipcrm ipcrm requested a review from a team as a code owner June 13, 2024 13:23
@ipcrm ipcrm force-pushed the ipcrm/GROW-2950/remove-gcp-audit-storage branch from 6fc84d0 to 3eb6a8f Compare July 16, 2024 13:21
@ipcrm ipcrm requested a review from a team as a code owner July 16, 2024 13:21
@ipcrm ipcrm requested review from theopolis, aneesh-mysore and surajswaminathan and removed request for a team July 16, 2024 13:21
@ipcrm ipcrm merged commit 5edd4ca into main Jul 16, 2024
13 checks passed
@ipcrm ipcrm deleted the ipcrm/GROW-2950/remove-gcp-audit-storage branch July 16, 2024 13:46
@lacework-releng lacework-releng mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants