Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2949): Provide organization_id for project level agentless integration #1648

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

leijin-lw
Copy link
Contributor

@leijin-lw leijin-lw commented Jul 16, 2024

Provide organization_id for project level agentless integration.

Summary

How did you test this change?

Tested using lacework generate cloud-account gcp command line to generate agentless terraform.

Issue

@leijin-lw leijin-lw requested a review from a team as a code owner July 16, 2024 16:49
@leijin-lw leijin-lw requested review from marktabry, PengyuanZhao, petrlw and ipcrm and removed request for a team, marktabry and petrlw July 16, 2024 16:49
@leijin-lw leijin-lw force-pushed the leijin-gcp-org branch 3 times, most recently from 1779609 to 3607c2a Compare July 16, 2024 17:00
Signed-off-by: Lei Jin <lei.jin@lacework.net>
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question on the new AgentlessOrganizationId

lwgenerate/gcp/gcp.go Show resolved Hide resolved
Signed-off-by: Lei Jin <lei.jin@lacework.net>
@leijin-lw leijin-lw requested a review from ipcrm July 16, 2024 17:38
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leijin-lw latest change looks good!

We also need to update the lacework generate cloud-account gcp command. Currently, if you use that command and enable agentless it doesn't require a org-id to be supplied. As I understand it that will prevent the agentless TF module from functioning correctly (apologies if I've got that wrong).

@leijin-lw
Copy link
Contributor Author

@leijin-lw latest change looks good!

We also need to update the lacework generate cloud-account gcp command. Currently, if you use that command and enable agentless it doesn't require a org-id to be supplied. As I understand it that will prevent the agentless TF module from functioning correctly (apologies if I've got that wrong).

I don't think we have support for agentless integration in CLI. As least agentless team didn't realize we have CLI to generate terraform last time I talked with them.

https://github.com/lacework/go-sdk/blob/main/cli/cmd/cloud_account.go#L294

@leijin-lw leijin-lw requested a review from ipcrm July 17, 2024 18:06
@leijin-lw leijin-lw force-pushed the leijin-gcp-org branch 2 times, most recently from 4925411 to 6d38ab6 Compare July 17, 2024 18:58
Signed-off-by: Lei Jin <lei.jin@lacework.net>
@leijin-lw leijin-lw merged commit 152359d into main Jul 18, 2024
13 checks passed
@leijin-lw leijin-lw deleted the leijin-gcp-org branch July 18, 2024 15:50
@lacework-releng lacework-releng mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants