-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GROW-2949): Provide organization_id for project level agentless integration #1648
Conversation
1779609
to
3607c2a
Compare
Signed-off-by: Lei Jin <lei.jin@lacework.net>
3607c2a
to
d9018d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question on the new AgentlessOrganizationId
Signed-off-by: Lei Jin <lei.jin@lacework.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leijin-lw latest change looks good!
We also need to update the lacework generate cloud-account gcp
command. Currently, if you use that command and enable agentless it doesn't require a org-id to be supplied. As I understand it that will prevent the agentless TF module from functioning correctly (apologies if I've got that wrong).
I don't think we have support for agentless integration in CLI. As least agentless team didn't realize we have CLI to generate terraform last time I talked with them. https://github.com/lacework/go-sdk/blob/main/cli/cmd/cloud_account.go#L294 |
4925411
to
6d38ab6
Compare
Signed-off-by: Lei Jin <lei.jin@lacework.net>
6d38ab6
to
8993869
Compare
Provide organization_id for project level agentless integration.
Summary
How did you test this change?
Tested using
lacework generate cloud-account gcp
command line to generate agentless terraform.Issue