Allow user to define cloudtrail name #1657
Conversation
leijin-lw
requested review from
goodmorninggoaway,
PengyuanZhao and
mjunglw
and removed request for
a team
| @@ -1050,6 +1050,9 @@ func createCloudtrail(args *GenerateAwsTfConfigurationArgs) (*hclwrite.Block, er | |||
| attributes["consolidated_trail"] = true | |||
| } | |||
| // S3 Bucket attributes | |||
| if args.CloudtrailName != "" { | |||
There was a problem hiding this comment.
Why adding this? Will the following if args.CloudtrailUseExistingTrail work?
There was a problem hiding this comment.
Because we want the user to define the new cloudtrail name. Existing go-sdk is using "lacework-cloudtrail" as default new cloudtrail name and we cannot change it.
There is a bug happen when user failed to delete the old "lacework-cloudtrail" and the new cloudtrail has to be a different name
There was a problem hiding this comment.
Isn't the code below (line 1054) attributes["cloudtrail_name"] = args.CloudtrailName using the passed in args.CloudtrailName?
There was a problem hiding this comment.
I get your point. I'll remove the line. attributes["cloudtrail_name"] should not depends onargs.CloudtrailUseExistingTrail
leijin-lw
force-pushed
the
leijin-lw-patch-1
branch
from
87a806e
to
0d18f2e
Compare
Signed-off-by: Lei Jin <lei.jin@lacework.net>
leijin-lw
force-pushed
the
leijin-lw-patch-1
branch
from
0d18f2e
to
b6aba2d
Compare
Summary
How did you test this change?
Issue