fix: pass integration type to all modules for multi region deployments #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammarekbote
requested review from
marktabry,
goodmorninggoaway and
aclacework
and removed request for
a team
leijin-lw
approved these changes
Sep 24, 2024
wilderj
approved these changes
Sep 24, 2024
japsingh
approved these changes
Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
integration_typeis an input variable for the terraform-gcp-agentless-scanning module.For multi region deployments there are multiple module block initializers - one for each region.
The
integration_typeneeds to be specified only for the global module block. For other module block, the integration type needs to be passed around in global module reference.How did you test this change?
Deployed multi region organization and project deployments to verify integration type is correctly applied for all regions.