Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not update private key id on read #531

Merged
merged 1 commit into from
Aug 16, 2023
Merged

fix: do not update private key id on read #531

merged 1 commit into from
Aug 16, 2023

Conversation

ammarekbote
Copy link
Collaborator

Summary
Terraform update for https://github.com/lacework/terraform-gcp-agentless-scanning fails as the private key id is empty.
On investigating with @afiune , we found that the patch workflow sends empty key instead of omitting it from the request.

How did you test this change?
Update the terraform provider with the go-sdk changes (lacework/go-sdk#1352) and pointed terraform module to use the provider. Terraform update went through successfully,

Issue
https://lacework.atlassian.net/browse/LINK-1923

@ammarekbote ammarekbote requested a review from a team as a code owner August 10, 2023 06:59
@dmurray-lacework
Copy link
Collaborator

I've approved the go-sdk change lacework/go-sdk#1352 (review)
Once the go-sdk change is merged the tf-provider deps can be updated.

@ammarekbote
Copy link
Collaborator Author

I've approved the go-sdk change lacework/go-sdk#1352 (review) Once the go-sdk change is merged the tf-provider deps can be updated.

@dmurray-lacework - I have merged the go-sdk changes. Do we need to release the go-sdk before updating the dependency? Also is make deps the right command to update the dependency

@dmurray-lacework
Copy link
Collaborator

I've approved the go-sdk change lacework/go-sdk#1352 (review) Once the go-sdk change is merged the tf-provider deps can be updated.

@dmurray-lacework - I have merged the go-sdk changes. Do we need to release the go-sdk before updating the dependency? Also is make deps the right command to update the dependency

Hey @ammarekbote the go-sdk dep has been updated and merged to main. You need to rebase this branch with main

@ammarekbote ammarekbote merged commit ff337a7 into main Aug 16, 2023
@ammarekbote ammarekbote deleted the LINK-1923 branch August 16, 2023 16:24
@lacework-releng lacework-releng mentioned this pull request Aug 21, 2023
Merged
@badass-aoz badass-aoz mentioned this pull request Nov 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmurray-lacework dmurray-lacework dmurray-lacework approved these changes

@afiune afiune Awaiting requested review from afiune

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammarekbote @dmurray-lacework