feat(PSP-1219): add provider for azure agentless integration #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badass-aoz
requested review from
ammarekbote,
japsingh,
dmurray-lacework and
jacobkilby
badass-aoz
commented
Nov 10, 2023
go.mod
Outdated
| @@ -11,6 +11,8 @@ require ( | |||
| golang.org/x/text v0.13.0 | |||
| ) | |||
|
|
|||
| replace github.com/lacework/go-sdk v1.37.0 => /Users/aoz/dev/go-sdk | |||
There was a problem hiding this comment.
was added for local test override. Will remove
japsingh
reviewed
Nov 11, 2023
japsingh
reviewed
Nov 11, 2023
|
|
||
| creds := make(map[string]string) | ||
| creds["client_id"] = integration.Data.Credentials.ClientId | ||
| d.Set("credentials", []map[string]string{creds}) |
There was a problem hiding this comment.
good question. I copied it from the GCP flow. Apparently it was intentionally removed (#531) so I'm just going to do the same here.
japsingh
reviewed
Nov 11, 2023
integration/azure_auth.go
Outdated
| ) | ||
|
|
||
| type azureCredentialsFile struct { | ||
| ClientSecret string `json:"keyId"` |
There was a problem hiding this comment.
Are these mapped incorrectly? Shouldn't keyId map to ClientID and secret map to ClientSecret?
japsingh
approved these changes
Nov 11, 2023
badass-aoz
changed the title
|
the test-build will require a rollout of lacework/go-sdk#1447 to work (had local override so it worked locally). I'll push for a release of go-sdk and run tests here. |
badass-aoz
force-pushed
the
new_azure_agentless_provider
branch
from
a6228b2
to
5238024
Compare
badass-aoz
force-pushed
the
new_azure_agentless_provider
branch
from
5238024
to
4dc3dd3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://lacework.atlassian.net/browse/PSP-1219
Description:
This adds lacework integration provider for Azure Agentless support.
Added an integration test for the change.
cd /Users/aoz/dev/terraform-provider-lacework/ && make build && make install && go mod vendor && cd integration && go test -v -run "TestIntegrationAzureAgentlessScanningCreate"passed