Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Root.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,15 @@ export class Root {

protected getExpired(expired?: number, ownTimeout?: number) {
try {
if (!expired) {
const timeout = ownTimeout || this.castToNumber(this.getSettingFromEnv('DEFAULT_RESPONSE_TIMEOUT'));
if (!expired && !ownTimeout) {
const timeout = this.castToNumber(this.getSettingFromEnv('DEFAULT_RESPONSE_TIMEOUT'));
return Date.now() + timeout;
}
if (ownTimeout) {
const customExpired = Date.now() + ownTimeout;
return Math.min(customExpired, expired);
return Date.now() + ownTimeout;
}
return expired;

return expired!;
} catch (error) {
this.logger.error(error);
process.exit(1);
Expand Down
2 changes: 1 addition & 1 deletion src/Service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,7 @@ export class Service<E extends Emitter = Emitter> extends Root {
this.rootSpans.set(newBaggage.traceId, span);
return {
...newBaggage,
expired: this.getExpired(undefined, ownTimeout),
expired: this.getExpired(newBaggage.expired, ownTimeout),
};
}

Expand Down
27 changes: 20 additions & 7 deletions src/__tests__/Client.ts
Original file line number Diff line number Diff line change
Expand Up @@ -71,19 +71,23 @@ describe('Testing Client class methods', () => {

test('Successful subscription and event processing for a streaming event', () => {
const payload = { data: { elapsed: 42 } };
jetstreamNextMock.mockResolvedValue({ data: codec.encode(payload.data), sid: '1', ack: jest.fn(), nak: jest.fn() });
jetstreamNextMock.mockResolvedValue({
data: codec.encode(payload.data),
sid: '1',
ack: jest.fn(),
nak: jest.fn(),
});

const result = mathClient.getListener('Test');
const handler = event => {
const handler = (event: any) => {
expect(event.data.elapsed).toBe(payload.data.elapsed);
result.off('Elapsed', handler);
}
};
result.on('Elapsed', handler);

});

test('Successful unsubscribe from the event', () => {
const subscribe = new PassThrough();
const subscribe: PassThrough & { unsubscribe?: jest.Mock } = new PassThrough();
subscribe['unsubscribe'] = jest.fn();
broker.subscribe.mockReturnValue(subscribe);

Expand Down Expand Up @@ -248,9 +252,18 @@ describe('Testing Client class methods', () => {
expired: Date.now() - 1,
});

const payload = { a: 5, b: 5 };
await expect(mathClient.fibonacci({ length: 5 })).rejects.toThrow();
});

await expect(mathClient.sum(payload)).rejects.toThrow();
test('If a method has own timeout, own timeout is more priority', async () => {
const mathClient = new MathClient(broker as any, {
spanId: '1',
traceId: '1',
traceFlags: 1,
expired: Date.now() - 1,
});

await mathClient.sum({ a: 5, b: 5 });
});

test('If the request returns an error, then an error is generated', async () => {
Expand Down