[CORE] Moved include in the CPP, using forward declaration instead

lagadic · Dec 4, 2024 · 07a306a · 07a306a
1 parent 412c791
commit 07a306a
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 3 deletions.
diff --git a/modules/core/include/visp3/core/vpXmlParser.h b/modules/core/include/visp3/core/vpXmlParser.h
@@ -45,15 +45,21 @@
 
 #include <visp3/core/vpException.h>
 
-#include <libxml/parser.h>
-
 #include <iomanip>
 #include <map>
 #include <sstream>
 #include <string.h>
 #include <string>
 #include <typeinfo>
 
+struct _xmlDoc;
+typedef _xmlDoc xmlDoc;
+typedef xmlDoc *xmlDocPtr;
+
+struct _xmlNode;
+typedef _xmlNode xmlNode;
+typedef xmlNode *xmlNodePtr;
+
 BEGIN_VISP_NAMESPACE
 /*!
   \class vpXmlParser
@@ -93,6 +99,8 @@ BEGIN_VISP_NAMESPACE
   A class to parse this document is declared as follows:
 
   \code
+  #include <libxml/parser.h>
+
   class vpDataParser: public vpXmlParser
   {
   private:
@@ -307,7 +315,7 @@ class VISP_EXPORT vpXmlParser
   static function vpXmlParser::cleanup() that calls xmlCleanupParser() that
   could be called just before exit().
     */
-  static void cleanup() { xmlCleanupParser(); }
+  static void cleanup();
   //@}
 };
 END_VISP_NAMESPACE

diff --git a/modules/core/src/tools/xml/vpXmlParser.cpp b/modules/core/src/tools/xml/vpXmlParser.cpp
@@ -482,6 +482,12 @@ void vpXmlParser::save(const std::string &filename, bool append)
   xmlSaveFormatFile(filename.c_str(), doc, 1);
   xmlFreeDoc(doc);
 }
+
+void vpXmlParser::cleanup()
+{
+  xmlCleanupParser();
+}
+
 END_VISP_NAMESPACE
 #elif !defined(VISP_BUILD_SHARED_LIBS)
 // Work around to avoid warning: libvisp_core.a(vpXmlParser.cpp.o) has no symbols

diff --git a/modules/core/test/tools/xml/testXmlParser.cpp b/modules/core/test/tools/xml/testXmlParser.cpp
@@ -58,6 +58,8 @@
 #include <visp3/core/vpXmlParser.h>
 #include <visp3/io/vpParseArgv.h>
 
+#include <libxml/parser.h>
+
 #include <string>
 
 #ifndef DOXYGEN_SHOULD_SKIP_THIS