Added C++17 checks to ensure that vpRGBa and vpRGBf are trivially cop…

…yable/assignable
lagadic · Sep 19, 2024 · 635acf8 · 635acf8
1 parent 25635f9
commit 635acf8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/modules/core/include/visp3/core/vpRGBa.h b/modules/core/include/visp3/core/vpRGBa.h
@@ -45,6 +45,11 @@
 #include <visp3/core/vpConfig.h>
 #include <visp3/core/vpColVector.h>
 
+#if (VISP_CXX_STANDARD > VISP_CXX_STANDARD_98)
+#include <type_traits>
+#endif
+
+
 BEGIN_VISP_NAMESPACE
 /*!
   \class vpRGBa
@@ -171,5 +176,12 @@ class VISP_EXPORT vpRGBa
 
   friend VISP_EXPORT vpRGBa operator*(const double &x, const vpRGBa &rgb);
 };
+
+#if (VISP_CXX_STANDARD > VISP_CXX_STANDARD_98)
+static_assert(std::is_trivially_assignable_v<vpRGBa, vpRGBa>);
+static_assert(std::is_trivially_copyable_v<vpRGBa>);
+#endif
+
+
 END_VISP_NAMESPACE
 #endif
diff --git a/modules/core/include/visp3/core/vpRGBf.h b/modules/core/include/visp3/core/vpRGBf.h
@@ -43,6 +43,10 @@
 #include <visp3/core/vpConfig.h>
 #include <visp3/core/vpColVector.h>
 
+#if (VISP_CXX_STANDARD >= VISP_CXX_STANDARD_17)
+#include <type_traits>
+#endif
+
 BEGIN_VISP_NAMESPACE
 
 /*!
@@ -103,7 +107,7 @@ class VISP_EXPORT vpRGBf
   /*!
     Copy constructor.
   */
-  inline vpRGBf(const vpRGBf &v) : R(v.R), G(v.G), B(v.B) { }
+  inline vpRGBf(const vpRGBf &v) = default;
 
   /*!
     Create a RGB value from a 3 dimensional column vector.
@@ -144,5 +148,15 @@ class VISP_EXPORT vpRGBf
   friend VISP_EXPORT vpRGBf operator*(double x, const vpRGBf &rgb);
   friend VISP_EXPORT vpRGBf operator*(float x, const vpRGBf &rgb);
 };
+
+#if (VISP_CXX_STANDARD > VISP_CXX_STANDARD_98)
+static_assert(std::is_trivially_assignable_v<vpRGBf, vpRGBf>);
+static_assert(std::is_trivially_copyable_v<vpRGBf>);
+#endif
+
+
 END_VISP_NAMESPACE
+
+
+
 #endif