Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megapose improvements #1216

Merged
merged 14 commits into from
Sep 2, 2023
Merged

Megapose improvements #1216

merged 14 commits into from
Sep 2, 2023

Conversation

SamFlt
Copy link
Contributor

@SamFlt SamFlt commented Aug 11, 2023

This PR brings some improvements to Megapose:

  • A fix for network communication in vpMegaPose on Windows
  • Notebook version made install fail
  • Add a verbose mode to print timings, showing render and model times
  • The client's disconnection from the server is now cleaner and does not generate an exception on the server
  • Added some documentation on using megapose on Windows: the server should be run in WSL, as it seems that there are some issues with panda3D on Windows
  • Added some documentation on the PBVS servoing example and referenced it in the megapose tracking tutorial
  • The default model is now RGB, as it is the most usable one (in terms of inference speed)
  • During install, if the user uses relative paths, they are converted to absolute ones in order for the megapose server to run from any directory

@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (3f74e10) 54.34% compared to head (506910d) 54.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   54.34%   54.32%   -0.03%     
==========================================
  Files         405      405              
  Lines       49822    49822              
==========================================
- Hits        27078    27068      -10     
- Misses      22744    22754      +10     

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fspindle
Copy link
Contributor

fspindle commented Sep 1, 2023

Ready to merge when ci ok

@fspindle fspindle merged commit eccc9d4 into lagadic:master Sep 2, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants