Introduce modern way to link with pthread library #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…build the embedded pthread library on windows
…conda package usage
Because there is an explicit link to libpthread location that breaks visp conda package usage on linux
we cannot use OpenMP_CXX_LIBRARIES that contains /usr/lib/gcc/x86_64-linux-gnu/11/libgomp.so;/usr/lib/x86_64-linux-gnu/libpthread.a
by adding:
list(APPEND opt_libs ${OpenMP_CXX_LIBRARIES})
That's why we need to use the modern way to consider pthread dependency
VISP_LINKER_LIBS are used as private - there is the need to make ws2_32.lib as a 3rd party public library - Consider now ws2_32.lib as a public 3rd party that is linked to core module - Rename deprecated LINK_PUBLIC and LINK_PRIVATE to PUBLIC and PRIVATE respectively
|
@olivier-roussel Moving Without this change, |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1227 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 405 405
Lines 49827 49827
=======================================
+ Hits 27077 27078 +1
+ Misses 22750 22749 -1
☔ View full report in Codecov by Sentry. |
|
Closes #1228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are related to Conda packaging where the following issues was encountered when visp conda package is used as a third-party. In
VISPModules.cmakethere remain the full absolute path of themandpthreadlibraries used during the package generation. When installing the conda package on a linux target, conda is unable to replace these locations with the corresponding ones on the target.The fix consists in:
mto export the library as private (Fixed in PR # 1226 commit e2ed222)pthreadto use modern cmake (commit 9de4530 and d6e5a2f)openmpthat has a dependency topthreadto consider the specific case ofpthreadas above (commit 9209898)ms2_32.libthat was part ofVISP_LINKER_LIBSthat contains now only private libraries, was removed fromVISP_LINKER_LIBSand considered as a classical 3rd party linked tovisp_coremodule (see commit 2c074db)See issue #1228